My first package attempt

pfr Now I need to add the patch.

Ah... erm, truth be told, I don't know--unlike you I'm still a pkgsrc virgin. Punting to @pin

One contribution I can make: the FreeBSD python patches will bring in an additional dependency: py38-psutil

rvp see https://www.unitedbsd.com/d/166-adding-patch-and-patch-file-to-a-pkgsrc-application or check directly 13.3.2 of the pkgsrc-guide.

pfr Do these patches need tweaking for NetBSD or will they do as they are?

see https://www.unitedbsd.com/d/166-adding-patch-and-patch-file-to-a-pkgsrc-application or check directly 13.3.2 of the pkgsrc-guide.

I need to give this another go. I was mid-semester during my principles of distributed computing class, and that was just time consuming so I didnt get to dedicate as much time playing around with pkgsrc. Definitely keep documenting your progress and what you learn! Ill be done with this session of classes soon and able to play again. So anything you can share, Ill definitely be looking at it!

pfr Do these patches need tweaking for NetBSD or will they do as they are?

You should be able to use the same patches if you use the same version as FreeBSD. A newer version might need different patches because the code has changed.

rvp A newer version might need different patches because the code has changed.

And this is the painfull part of maintaing patches

pin Yah--Another headache is what I term "patrolling"--keeping an eye on the various websites/mailing-lists/whatever to see if new versions have dropped; then judging if the new versions merit a new package or should be skipped... Our friend will learn all this in due course.

@pfr: if you get a taste for this, tell me. I have another thing lined up for you to package (I've done the NetBSD-related work already; just got to do the FreeBSD stuff, then send it upstream). It's something you've already requested... but I'll keep it as a surprise for the time being.

pfr So I couldn't get it to work with the lates version

Try this (a minor update was needed):

diff -urN ueberzug-18.1.9.orig/Xshm/Xshm.c ueberzug-18.1.9/Xshm/Xshm.c
--- ueberzug-18.1.9.orig/Xshm/Xshm.c	2021-01-09 11:39:14.000000000 +0000
+++ ueberzug-18.1.9/Xshm/Xshm.c	2021-06-22 07:39:45.134536810 +0000
@@ -67,9 +67,6 @@
 
     if (self->segmentInfo.shmaddr != INVALID_SHM_ADDRESS) {
         self->segmentInfo.readOnly = true;
-        // Mark the shared memory segment for removal
-        // It will be removed even if this program crashes
-        shmctl(self->segmentInfo.shmid, IPC_RMID, 0);
         return true;
     }
 
@@ -111,6 +108,7 @@
 Image_free_shared_memory(Image *self) {
     if(self->segmentInfo.shmaddr != INVALID_SHM_ADDRESS) {
         shmdt(self->segmentInfo.shmaddr);
+        shmctl(self->segmentInfo.shmid, IPC_RMID, 0);
         self->segmentInfo.shmaddr = INVALID_SHM_ADDRESS;
     }
 }
diff -urN ueberzug-18.1.9.orig/examples/fzfimg.sh ueberzug-18.1.9/examples/fzfimg.sh
--- ueberzug-18.1.9.orig/examples/fzfimg.sh	2021-01-09 11:39:14.000000000 +0000
+++ ueberzug-18.1.9/examples/fzfimg.sh	2021-06-22 07:39:45.135089990 +0000
@@ -18,7 +18,7 @@
 readonly REDRAW_COMMAND="toggle-preview+toggle-preview"
 readonly REDRAW_KEY="µ"
 declare -r -x DEFAULT_PREVIEW_POSITION="right"
-declare -r -x UEBERZUG_FIFO="$(mktemp --dry-run --suffix "fzf-$$-ueberzug")"
+declare -r -x UEBERZUG_FIFO="$(T="$(mktemp -t fzf-$$-ueberzug)"; rm -f "$T"; echo "$T")"
 declare -r -x PREVIEW_ID="preview"
 
 
diff -urN ueberzug-18.1.9.orig/ueberzug/query_windows.py ueberzug-18.1.9/ueberzug/query_windows.py
--- ueberzug-18.1.9.orig/ueberzug/query_windows.py	2021-01-09 11:39:14.000000000 +0000
+++ ueberzug-18.1.9/ueberzug/query_windows.py	2021-06-22 07:39:45.135911143 +0000
@@ -2,6 +2,7 @@
 import signal
 import errno
 
+import psutil
 
 def get_command(pid):
     """Figures out the associated command name
@@ -13,8 +14,7 @@
     Returns:
         str: the associated command name
     """
-    with open('/proc/{}/comm'.format(pid), 'r') as commfile:
-        return '\n'.join(commfile.readlines())
+    psutil.Process(pid=pid).name()
 
 
 def is_same_command(pid0, pid1):
diff -urN ueberzug-18.1.9.orig/ueberzug/xutil.py ueberzug-18.1.9/ueberzug/xutil.py
--- ueberzug-18.1.9.orig/ueberzug/xutil.py	2021-01-09 11:39:14.000000000 +0000
+++ ueberzug-18.1.9/ueberzug/xutil.py	2021-06-22 07:40:05.091510744 +0000
@@ -1,6 +1,7 @@
 """This module contains x11 utils"""
 import functools
 import asyncio
+import psutil
 
 import Xlib
 import Xlib.display as Xdisplay
@@ -144,9 +145,9 @@
     the first process in the passed list which owns one.
     """
     for pid in pids:
-        pty_slave_file = process.get_pty_slave(pid)
-        if pty_slave_file:
-            return pty_slave_file
+        process = psutil.Process(pid=pid)
+        if process is not None and process.terminal() is not None:
+            return process.terminal()
 
     return None

pfr Nice! Minor nitpick...
On your Makefile,

# $NetBSD$

GITHUB_PROJECT= ueberzug
GITHUB_TAG= refs/tags/18.1.9
DISTNAME=   18.1.9
PKGNAME=    ${GITHUB_PROJECT}-${DISTNAME}
CATEGORIES= local
MASTER_SITES=   ${MASTER_SITE_GITHUB:=seebye/}
DIST_SUBDIR=    ${GITHUB_PROJECT}# $NetBSD$

this can be simplified to the following,

# $NetBSD$

DISTNAME=	ueberzug-18.1.9
CATEGORIES=	graphics
MASTER_SITES=	${MASTER_SITE_GITHUB:=seebye/}

Also, this might actually be more correct as a py-pkg.