NetBSD 11.0 Build jgmenu

shep

I use OpenBox, tint2 and jgmenu for my work flow and would like to implement it in NetBSD.
With the exception of jgmenu, it is ready to go. I've even have a yad --scale audio volume slider for tint2's system tray.

My steps:

Extract latest, stable code, jgmenu-4.6, to /usr/pkg

./configure --prefix=/usr/pkg
gmake

I get the following error:
ld: cannot find -lpng: no such file or directory.
The png package is installed.
Makefile line 73 is implicated
73 $(QUIET_LINK)$(CC) $(CFLAGS) -o $@ $^ $(LDFLAGS)

I've tried searching for NetBSD LDFLAGS -lpng without any success.

I'd appreciate any guideance.

rvp

shep Can you try this patch?

diff -urN jgmenu-4.6.0.orig/Makefile jgmenu-4.6.0/Makefile
--- jgmenu-4.6.0.orig/Makefile	2026-08-07 18:18:13.000000000 +0000
+++ jgmenu-4.6.0/Makefile	2026-09-04 07:39:01.551491660 +0000
@@ -13,14 +13,13 @@
 -include config.mk
 include Makefile.inc
 
-jgmenu:         CFLAGS += `pkg-config cairo pango pangocairo $(RSVG_LIB) --cflags` $(RSVG_FLAGS)
+jgmenu:         CFLAGS += -pthread `pkg-config libpng cairo pango pangocairo $(RSVG_LIB) --cflags` $(RSVG_FLAGS)
 jgmenu-ob:      CFLAGS += `pkg-config --cflags libxml-2.0`
 jgmenu-obtheme: CFLAGS += `pkg-config --cflags libxml-2.0`
 jgmenu-config:  CFLAGS += `pkg-config --cflags glib-2.0`
 jgmenu-apps:    CFLAGS += `pkg-config --cflags glib-2.0`
 
-jgmenu:         LIBS   += `pkg-config x11 xrandr cairo pango pangocairo $(RSVG_LIB) --libs` $(RSVG_FLAGS)
-jgmenu:         LIBS   += -pthread -lpng
+jgmenu:         LIBS   += `pkg-config x11 xrandr libpng cairo pango pangocairo $(RSVG_LIB) --libs` $(RSVG_FLAGS)
 jgmenu-ob:      LIBS   += `pkg-config --libs libxml-2.0`
 jgmenu-obtheme: LIBS   += `pkg-config --libs libxml-2.0`
 jgmenu-config:  LIBS   += `pkg-config --libs glib-2.0`
diff -urN jgmenu-4.6.0.orig/src/argv-buf.c jgmenu-4.6.0/src/argv-buf.c
--- jgmenu-4.6.0.orig/src/argv-buf.c	2026-08-07 18:18:13.000000000 +0000
+++ jgmenu-4.6.0/src/argv-buf.c	2026-09-04 07:02:53.855515505 +0000
@@ -75,7 +75,7 @@
 	for (i = 0; i < buf->argc; i++) {
 		p = buf->argv[i];
 		rtrim(&p);
-		while (isspace(*p))
+		while (isspace((unsigned char)*p))
 			p++;
 		buf->argv[i] = p;
 	}
diff -urN jgmenu-4.6.0.orig/src/filter.c jgmenu-4.6.0/src/filter.c
--- jgmenu-4.6.0.orig/src/filter.c	2026-08-07 18:18:13.000000000 +0000
+++ jgmenu-4.6.0/src/filter.c	2026-09-04 07:03:09.789656457 +0000
@@ -86,7 +86,7 @@
 
 	do {
 		filter_backspace();
-	} while (!isspace(needle.buf[needle.len-1]) && needle.len);
+	} while (!isspace((unsigned char)needle.buf[needle.len-1]) && needle.len);
 }
 
 void filter_reset(void)
diff -urN jgmenu-4.6.0.orig/src/sbuf.c jgmenu-4.6.0/src/sbuf.c
--- jgmenu-4.6.0.orig/src/sbuf.c	2026-08-07 18:18:13.000000000 +0000
+++ jgmenu-4.6.0/src/sbuf.c	2026-09-04 07:03:25.581642694 +0000
@@ -115,7 +115,7 @@
 	if (!s || !s->buf || !s->len)
 		return;
 	p = s->buf;
-	while (i < s->len && isspace(*p++))
+	while (i < s->len && isspace((unsigned char)*p++))
 		i++;
 	sbuf_shift_left(s, i);
 }
@@ -129,7 +129,7 @@
 		return;
 	p = s->buf + s->len - 1;
 	while (i < s->len) {
-		if (!isspace(*p))
+		if (!isspace((unsigned char)*p))
 			break;
 		i++;
 		p--;
diff -urN jgmenu-4.6.0.orig/src/util.c jgmenu-4.6.0/src/util.c
--- jgmenu-4.6.0.orig/src/util.c	2026-08-07 18:18:13.000000000 +0000
+++ jgmenu-4.6.0/src/util.c	2026-09-04 07:03:40.005673546 +0000
@@ -106,7 +106,7 @@
 	if (!len)
 		return;
 	end = *s + len - 1;
-	while (end >= *s && isspace(*end))
+	while (end >= *s && isspace((unsigned char)*end))
 		end--;
 	*(end + 1) = '\0';
 }
@@ -114,7 +114,7 @@
 char *strstrip(char *s)
 {
 	rtrim(&s);
-	while (isspace(*s))
+	while (isspace((unsigned char)*s))
 		s++;
 	return s;
 }

shep

Thanks, I applied your patch and it built but unfortunately both jgmenu and jgmenu_run produce a core dump and no error messages in the terminal or in ~/.xsession-errs

At the suggestion of jgmenu upstream is also tried:

jgmenu:         LIBS   += `pkg-config x11 xrandr cairo pango pangocairo $(RSVG_LIB) --libs` $(RSVG_FLAGS)
-jgmenu:         LIBS   += -pthread -lpng16

Both your patch and -lpng -> -lpng16 will build and generate the following warning:

     LINK  jgmenu-apps

ld: warning: libintl.so.1, needed by /usr/pkg/lib/libglib-2.0.so, may conflict with libintl.so.8
ld: warning: libintl.so.1, needed by /usr/pkg/lib/libglib-2.0.so, may conflict with libintl.so.8
     CC    jgmenu-config.o
     LINK  jgmenu-config
ld: warning: libintl.so.1, needed by /usr/pkg/lib/libglib-2.0.so, may conflict with libintl.so.8
ld: warning: libintl.so.1, needed by /usr/pkg/lib/libglib-2.0.so, may conflict with libintl.so.8

It's getting late in my time zone but will work on tomorrow. Ultimately, if it can be built and I can generate a pkgsrc build, I'd like to submit it.

rvp

shep Can't reproduce this on 11.0_STABLE or 10.1-RELEASE. make test in the package passed and jgmenu --simple produced the expected menu from items read from stdin

I can't see what's bringing in that libintl.so.8. When I tried this on a fresh install, only the system libintl was needed. What version of NetBSD are you running?

Can you recompile jgmenu with -O0 -ggdb and then get a stack trace in gdb?

I've updated the patch (for 11.0)--try that too.

shep

I'm running 11.0 release amd64
Tried the update patch - no change.
I'm using gmake to compile based on the FreeBSD/OpenBSD build scripts, gmake won't take the -O0 -ggdb flag.

I'm wondering if I missed any thing preparing to compile in /usr/pkg rather than /usr/pkgsrc?
Edit: I reviewed the changlog for 11.1 and there was a fix for ld.elf.
I'm upgrading to -stable and will give it another shot.

rvp

shep I'm using gmake to compile based on the FreeBSD/OpenBSD build scripts,

Didn't get this. What do you mean by build scripts? It's just right?:

./configure --prefix=/SOME/PATH
gmake
gmake install prefix=/SOME/PATH

gmake won't take the -O0 -ggdb flag.

Edit jgmenu-4.6.0/Makefile.inc and change -Os to -O0

shep I'm wondering if I missed any thing preparing to compile in /usr/pkg rather than /usr/pkgsrc?

/usr/pkg is the default installed prefix for packages built using the sources in /usr/pkgsrc, so you shouldn't be using either for your own stuff (unless you want to make this part of pkgsrc?). Just let it use /usr/local like it wants to.

Can you run script and do all the compilation steps inside it so that we can see what's happening? Run gmake VERBOSE=1 for the compilation step.

shep

With pkg-config installed, I edited Makefile and Makefile.inc and ran gmake; gmake -install.
Ran the /usr/local/bin/jgmenu_run binaries with:

ld: /usr/lib/libm.so.0: warning: warning: reference to compatibility cabsf()
     CC    jgmenu-apps.o
     CC    desktop.o
     CC    dirs.o
     CC    lang.o
     CC    fmt.o
     LINK  jgmenu-apps
ld: warning: libintl.so.1, needed by /usr/pkg/lib/libglib-2.0.so, may conflict with libintl.so.8
ld: warning: libintl.so.1, needed by /usr/pkg/lib/libglib-2.0.so, may conflict with libintl.so.8
     CC    jgmenu-config.o
     LINK  jgmenu-config
ld: warning: libintl.so.1, needed by /usr/pkg/lib/libglib-2.0.so, may conflict with libintl.so.8
ld: warning: libintl.so.1, needed by /usr/pkg/lib/libglib-2.0.so, may conflict with libintl.so.8
# gmake install
# ls /usr/pkg/bin/jg*
ls: /usr/pkg/bin/jg*: No such file or directory
# ls /usr/local/
bin/      libexec/  share/    
# ls /usr/local/bin/                                                                                                    
jgmenu     jgmenu_run
# exit
$ /usr/local/bin/jgmenu_run
Memory fault

I took the partitioning defaults on my install of 11.0-stable

Filesystem     512-blocks         Used        Avail %Cap Mounted on
/dev/dk1        929992488     28771640    854721224   4% /
tmpfs             7966288           16      7966272   1% /tmp
kernfs                  2            2            0 100% /kern
ptyfs                   2            2            0 100% /dev/pts
procfs                  8            8            0 100% /proc
tmpfs             7966288        10496      7955792   1% /var/shm

rvp

shep Ran the /usr/local/bin/jgmenu_run binaries with:

This doesn't move us any forrarder, mate; it's all the same info. as before. I want to see,

a) the stack trace in gdb (run gdb /SOME/PATH/prog /OTHER/PATH/prog.core, then bt at the (gdb) prompt).

b) the entirety of the configuration and compilation steps (with make VERBOSE=1 so that I can see what's pulling in libintl.so.8--nothing causes that when I tried here even--with librsvg installed).

shep I took the partitioning defaults on my install of 11.0-stable

That looks very standard and shouldn't cause any problems.

shep

I had not applied your full patch - I had not scrolled down and did not copy the full patch. It now builds and runs.
There was a caveat, it lacked the *.desktop entries in /usr/pkg/share/applications and the icons.

I recalled that was an issue with LXDE and exporting
reference

export XDG_CONFIG_DIRS=/usr/pkg/etc/xdg
export XDG_DATA_DIRS=/usr/pkg/share

in my .xsession fixed. On logout, it does leave a stale .jgmenu-lockfile which I configured my ~/.config/openbox/autostart to delete prior to running jgmenu --hide-on-startup to reduce the latency for initial use after login.

It's obvious you put a lot of work into generating the patch and I thank you for staying with this.

I'm willing to take a shot at making a pkgscr build - I did the original OpenBSD port for jgmenu. I stepped through the OpenBSD porting guide

Is there something similar for NetBSD? I'm retired, not a programmer by training and would need a fair amount of hand holding to generate a pkgscr submission.

I think jgmenu is a very helpful package that would be widely used. With openbox and tint2 it makes a very functional and light work environment.

Jay

shep for porting to pkgsrc this guide will help:

https://www.netbsd.org/docs/pkgsrc/developers-guide.html

shep

I'd like to mark this [Solved] if possible. Didn't see a path when trying to edit the original post.

Jay

shep you can click "Select best answer" from any post 🙂

rvp

shep I had not applied your full patch - It now builds and runs.

Great, be sure to send the patch upstream. The changes are:

-pthread is also a pre-processor option; use it as such so that macros like -D_REENTRANT and -D_PTHREADS get defined when compiling source.
Use pkg-config to bring in libpng too.
Pass unsigned chars only to the isXXX() functions--as reqd. by ANSI C.

shep It's obvious you put a lot of work into generating the patch [...]

Not really; figuring out how to generate menus was more trouble. 😃

shep

rvp

An email from upstream:

Thanks. Have merged those changes. They were a good catch and should be fixed
regardless of this BSD related discussion.

In the interest of putting together a submission, it may be prudent to wait for the merged code to be released, it would save having to break down the patch file by file.

shep

Jgmenu release 4.7.0

I don't feel that @rvp got the credit for his patch - I functioned more as a go-between.
I'll submit @rvp if that is how you want to be identified.

Also, will start working through the pkgsrc documentation, linked above, to put together a jgmenu build. I do have a github account so I think I can submit via github.

rvp

shep I'll submit @rvp if that is how you want to be identified.

Please don't bother--'twas a very minor patch as I said.

shep

rvp
Everything has fallen into place up to this point. I have pkglint "looks fine" on a wip build.
Builds and runs on NetBSD 11.0-STABLE.
I'm wondering how to submit? Ideally, this is a one-off for me and if I can avoid setting up an account that would be minimally used, if at all. it would be good. I tried sending an email to pkgsrc-wip but it has not shown up in the archives after 8 hours.

Could anyone on the forum sponsor?

Jay

shep sometimes it takes time to reach mailing list.

Jay

shep for setting up commit access for wip check this page https://pkgsrc.org/wip/